Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic device support to dft domain through portFFT #570

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

s-Nick
Copy link
Contributor

@s-Nick s-Nick commented Sep 9, 2024

Description

This PR is the continuation of PR #566 and it is based on it.
It adds generic devices support by enabling portFFT and generic device the same way it is done for portBLAS.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
    • I don't have a non Intel/NVIDIA/AMD device to test with. Tests are successful when forcing Intel devices to go through generic_device path.

Following logs show that all domains still work properly:
portfft_log.txt
arc_blas_log.txt
cufft_log.txt
arc_lapack_log.txt
arc_rng_log.txt

  • Have you formatted the code using clang-format?

New features

@s-Nick s-Nick requested a review from Rbiessy September 9, 2024 13:22
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/building_the_project_with_dpcpp.rst Outdated Show resolved Hide resolved
@s-Nick s-Nick marked this pull request as ready for review October 1, 2024 08:37
@s-Nick s-Nick changed the title [DRAFT] Add generic device support to dft domain through portFFT Add generic device support to dft domain through portFFT Oct 1, 2024
@s-Nick s-Nick requested a review from a team October 3, 2024 09:59
Copy link
Contributor

@lhuot lhuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Rbiessy Rbiessy merged commit ea19c29 into oneapi-src:develop Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants